Skip to content

Commit

Permalink
Merge pull request #29186 from storybookjs/version-patch-from-8.3.2
Browse files Browse the repository at this point in the history
Release: Patch 8.3.3
  • Loading branch information
kasperpeulen authored Sep 24, 2024
2 parents ee03ab0 + bfc73ac commit 544ffdf
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 14 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 8.3.3

- CLI: Show constraints in error when getting depndencies - [#29187](https://github.com/storybookjs/storybook/pull/29187), thanks @andrasczeh!
- React-Vite: Downgrade react-docgen-typescript plugin - [#29184](https://github.com/storybookjs/storybook/pull/29184), thanks @shilman!
- UI: Fix composed storybook TooltipLinkList bug where href isn't passed forward - [#29175](https://github.com/storybookjs/storybook/pull/29175), thanks @JSMike!

## 8.3.2

- CLI: Fix skip-install for stable latest releases - [#29133](https://github.com/storybookjs/storybook/pull/29133), thanks @valentinpalkovic!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export abstract class JsPackageManager {
.find((version) => satisfies(version, constraint));
invariant(
latestVersionSatisfyingTheConstraint != null,
'No version satisfying the constraint.'
`No version satisfying the constraint: ${packageName}${constraint}`
);
return latestVersionSatisfyingTheConstraint;
}
Expand Down
2 changes: 1 addition & 1 deletion code/core/src/components/components/tooltip/ListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ const getItemProps = memoize(100)((onClick, href, LinkWrapper) => ({

export type LinkWrapperType = (props: any) => ReactNode;

export interface ListItemProps extends Omit<ComponentProps<typeof Item>, 'href' | 'title'> {
export interface ListItemProps extends Omit<ComponentProps<typeof Item>, 'title'> {
loading?: boolean;
title?: ReactNode;
center?: ReactNode;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface Link extends Omit<ListItemProps, 'onClick'> {
id: string;
onClick?: (
event: SyntheticEvent,
item: Pick<ListItemProps, 'id' | 'active' | 'disabled' | 'title'>
item: Pick<ListItemProps, 'id' | 'active' | 'disabled' | 'title' | 'href'>
) => void;
}

Expand All @@ -31,11 +31,11 @@ interface ItemProps extends Link {
}

const Item = ({ id, onClick, ...rest }: ItemProps) => {
const { active, disabled, title } = rest;
const { active, disabled, title, href } = rest;

const handleClick = useCallback(
(event: SyntheticEvent) => onClick?.(event, { id, active, disabled, title }),
[onClick, id, active, disabled, title]
(event: SyntheticEvent) => onClick?.(event, { id, active, disabled, title, href }),
[onClick, id, active, disabled, title, href]
);

return <ListItem id={`list-item-${id}`} {...rest} {...(onClick && { onClick: handleClick })} />;
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/react-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@joshwooding/vite-plugin-react-docgen-typescript": "0.3.1",
"@joshwooding/vite-plugin-react-docgen-typescript": "0.3.0",
"@rollup/pluginutils": "^5.0.2",
"@storybook/builder-vite": "workspace:*",
"@storybook/react": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -295,5 +295,6 @@
"Dependency Upgrades"
]
]
}
},
"deferredNextVersion": "8.3.3"
}
10 changes: 5 additions & 5 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3677,9 +3677,9 @@ __metadata:
languageName: node
linkType: hard

"@joshwooding/vite-plugin-react-docgen-typescript@npm:0.3.1":
version: 0.3.1
resolution: "@joshwooding/vite-plugin-react-docgen-typescript@npm:0.3.1"
"@joshwooding/vite-plugin-react-docgen-typescript@npm:0.3.0":
version: 0.3.0
resolution: "@joshwooding/vite-plugin-react-docgen-typescript@npm:0.3.0"
dependencies:
glob: "npm:^7.2.0"
glob-promise: "npm:^4.2.0"
Expand All @@ -3691,7 +3691,7 @@ __metadata:
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/a9c7a03d7d1daf5bd64949255516ba64c88d5600366c8c74dcdb6f37c2a6099daaec02860b7587d2220e61afa47a0b2de17ef70d723c2db02f24e0890edfd9f3
checksum: 10c0/31098ad8fcc2440437534599c111d9f2951dd74821e8ba46c521b969bae4c918d830b7bb0484efbad29a51711bb62d3bc623d5a1ed5b1695b5b5594ea9dd4ca0
languageName: node
linkType: hard

Expand Down Expand Up @@ -6708,7 +6708,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/react-vite@workspace:frameworks/react-vite"
dependencies:
"@joshwooding/vite-plugin-react-docgen-typescript": "npm:0.3.1"
"@joshwooding/vite-plugin-react-docgen-typescript": "npm:0.3.0"
"@rollup/pluginutils": "npm:^5.0.2"
"@storybook/builder-vite": "workspace:*"
"@storybook/react": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion docs/versions/latest.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"8.3.2","info":{"plain":"- CLI: Fix skip-install for stable latest releases - [#29133](https://github.com/storybookjs/storybook/pull/29133), thanks @valentinpalkovic!\n- Core: Do not add packageManager field to package.json during `storybook dev` - [#29152](https://github.com/storybookjs/storybook/pull/29152), thanks @valentinpalkovic!"}}
{"version":"8.3.3","info":{"plain":"- CLI: Show constraints in error when getting depndencies - [#29187](https://github.com/storybookjs/storybook/pull/29187), thanks @andrasczeh!\n- React-Vite: Downgrade react-docgen-typescript plugin - [#29184](https://github.com/storybookjs/storybook/pull/29184), thanks @shilman!\n- UI: Fix composed storybook TooltipLinkList bug where href isn't passed forward - [#29175](https://github.com/storybookjs/storybook/pull/29175), thanks @JSMike!"}}

0 comments on commit 544ffdf

Please sign in to comment.