Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transform)!: meta no longer destructurable from defineMeta() call #244

Merged
merged 15 commits into from
Dec 18, 2024

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented Dec 13, 2024

This was requested privately by @JReinhold. Is supposed to unlock his work on #213.

For the users, it changes nothing. Unless they were hacking around the internals by destructuring manually meta from defineMeta() call.

tl;dr: In the compiled output:

- const { Story, meta } = defineMeta({
+ const meta = {
  component: Button,
  title: 'hello'
- }); 
+ };
+ const { Story } = defineMeta(meta);

export default meta;

@xeho91 xeho91 added patch Increment the patch version when merged internal Changes only affect the internal API next Related to the next version labels Dec 13, 2024
@xeho91 xeho91 requested a review from JReinhold December 13, 2024 15:17
Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. ❤️

@JReinhold JReinhold merged commit c5692e0 into next Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API next Related to the next version patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants