Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v3.0.json #2722

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update v3.0.json #2722

wants to merge 1 commit into from

Conversation

Learnfr
Copy link

@Learnfr Learnfr commented Nov 6, 2024

there is a duplicate apikey, it should be http and not apikey

Fixes #[ISSUE_NUMBER].

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

If indicated yes above, please describe the breaking change(s).

Remove this quote before creating the PR.

Screenshots

If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots section before creating the PR.

Additional context

Add any other context about the pull request here. Remove this section if there is no additional context.

there is a duplicate apikey, it should be http and not apikey
@Learnfr Learnfr requested a review from a team as a code owner November 6, 2024 15:04
@mnaumanali94
Copy link
Contributor

@Learnfr Can we please change the commit message to follow semantic commits

@Learnfr
Copy link
Author

Learnfr commented Nov 14, 2024

@mnaumanali94 yes you could change the commit message

@mnaumanali94
Copy link
Contributor

@Learnfr Considering its your PR it would be the easiest for you to amend the commit or close this PR and create a new one. We would really appreciate that. Once these tests/linting passes we can review it.

@mnaumanali94
Copy link
Contributor

@Learnfr Gentle reminder to take a look at this if you can 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants