-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin @stoplight/json dep to 3.20.0 #2567
base: master
Are you sure you want to change the base?
Conversation
cc @chohmann – any chance you could give this a quick stamp? the bad dep causes things to be Very Broken. |
cc @mnaumanali94 can anyone take a look at this? it's breaking everything for us |
@RobertCraigie The team should be able to look at this tomorrow. We're in a bit of a transition in terms of ownership - we apologize for the wait. |
@mnaumanali94 anything we could do to persuade you to go ahead and release this? It's just a dependency pin to a previous-known-good version, and the breakage is quite bad (for us at least, and it seems, others too). |
@rattrayalex This issue should be fixed now as a new version of stoplight/json should fix the error. Can y'all confirm please? |
Amazing, thank you @mnaumanali94 ! We'll give it a try shortly! |
It looks like it's still failing but I haven't verified if this CI run is using the new stoplight/json version or not. We've published a fork of |
Is there a reason you are reverting to 3.20.0 and not 3.21.0? |
Also trying on the command line with the steps to reproduce It doesn't fail. Can you see if the CI is using the right version? |
@mnaumanali94 see this CI run which includes a debug log showing the versions of all deps. It's using |
Resolves #2578 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yjp20 sorry for the delay, could you resolve conflicts?
Addresses #2566
Checklist