fix(scripts): add webNavigation listener after firefox restart

stoically · Aug 10, 2020 · e832ae5 · e832ae5
1 parent a19e634
commit e832ae5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/src/background/event-listeners.ts b/src/background/event-listeners.ts
@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { TemporaryContainers } from './tmp';
-import { Debug, Permissions } from '~/types';
+import { Debug } from '~/types';
 
 // to have persistent listeners we need to register them early+sync
 // and wait for tmp to fully initialize before handling events
@@ -166,15 +166,14 @@ export class EventListeners {
     this.registerPermissionedListener();
   }
 
-  registerPermissionedListener(permissions?: Permissions): void {
-    permissions?.webNavigation &&
-      browser.webNavigation?.onCommitted.addListener(
-        this.wrap(
-          browser.webNavigation?.onCommitted,
-          this.background.scripts,
-          'maybeExecute'
-        )
-      );
+  registerPermissionedListener(): void {
+    browser.webNavigation?.onCommitted.addListener(
+      this.wrap(
+        browser.webNavigation?.onCommitted,
+        this.background.scripts,
+        'maybeExecute'
+      )
+    );
   }
 
   wrap(

diff --git a/src/background/preferences.ts b/src/background/preferences.ts
@@ -153,7 +153,7 @@ export class Preferences {
     }
     if (!this.permissions.webNavigation && newPreferences.scripts.active) {
       this.permissions.webNavigation = true;
-      this.eventlisteners.registerPermissionedListener(this.permissions);
+      this.eventlisteners.registerPermissionedListener();
     }
 
     if (