chore: code review feedback.

Author: peterhuene

wdl-engine/src/eval.rs

@@ -640,8 +640,11 @@ pub struct InputTrie {
 }
 
 impl InputTrie {
-    /// Constructs a new inputs trie with the given guest inputs directory.
-    pub fn new(guest_inputs_dir: &'static str) -> Self {
+    /// Constructs a new inputs trie with a guest inputs directory.
+    ///
+    /// Inputs with a host path will be mapped to a guest path relative to the
+    /// guest inputs directory.
+    pub fn new_with_guest_dir(guest_inputs_dir: &'static str) -> Self {
         Self {
             guest_inputs_dir: Some(guest_inputs_dir),
             ..Default::default()
@@ -650,6 +653,11 @@ impl InputTrie {
 
     /// Inserts a new input into the trie.
     ///
+    /// The `path` parameter is a `File` or `Directory` value (as a string) to
+    /// treat as an input.
+    ///
+    /// It may be either a local or remote path.
+    ///
     /// Returns `Ok(Some(_))` if an input was added.
     ///
     /// Returns `Ok(None)` if the provided path was already a guest input path
@@ -939,7 +947,7 @@ mod test {
     #[cfg(unix)]
     #[test]
     fn non_empty_trie_unix() {
-        let mut trie = InputTrie::new("/inputs");
+        let mut trie = InputTrie::new_with_guest_dir("/inputs");
         trie.insert(InputKind::Directory, "/").unwrap().unwrap();
         trie.insert(InputKind::File, "/foo/bar/foo.txt")
             .unwrap()
@@ -1029,7 +1037,7 @@ mod test {
     #[cfg(windows)]
     #[test]
     fn non_empty_trie_windows() {
-        let mut trie = InputTrie::new("/inputs");
+        let mut trie = InputTrie::new_with_guest_dir("/inputs");
         trie.insert(InputKind::Directory, "C:\\").unwrap().unwrap();
         trie.insert(InputKind::File, "C:\\foo\\bar\\foo.txt")
             .unwrap()

wdl-engine/src/eval/v1/task.rs

@@ -632,7 +632,7 @@ impl<'a> State<'a> {
         ];
 
         let mut inputs = if let Some(roots) = guest_roots {
-            InputTrie::new(roots.inputs_dir)
+            InputTrie::new_with_guest_dir(roots.inputs_dir)
         } else {
             InputTrie::default()
         };