Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardened compiled '--with-uploadscript' and Environment Var 'FTP_UPLOADSCRIPT' #173

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

adisadi
Copy link

@adisadi adisadi commented Nov 22, 2021

No description provided.

stilliard and others added 30 commits November 21, 2015 12:24
Bug fix for incorrect configuration on 'hardened' branch.
…ntly use the debian wrapper that would parse these, see issue stilliard#38
@stilliard
Copy link
Owner

Hey @adisadi

Thanks for the contribution!
Looks interesting, I've not used the uploadscripts before but will check this out.

Quick question, does this need to be off the hardened branch? Would it work if we cherry picked the commits needed onto a branch off master instead?

Thanks

@adisadi
Copy link
Author

adisadi commented Nov 22, 2021

Hi,
Thanks for your project 👍.
No this doesn't needs to be off the hardened branch. I just use this branch. Can you do the cherry picking? I'm not a git pro... :-).

@JensWilhelmssonSH
Copy link

@adisadi , is your fork fully functional with upload scripts? Env FTP_UPLOADSCRIPT to path of script inside container and a volume to pass the script in are all that is needed?

Regards,
Jens

@adisadi
Copy link
Author

adisadi commented Nov 29, 2021

Yes exactly. You also need the "-o / --uploadscript" Flag in "ADDED_FLAGS" Env. And only the branch hardened-with-uploadscript

@JensWilhelmssonSH
Copy link

@adisadi Great! It works now. Many thanks.

Regards
Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants