Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the phone screen leaflet exit animation #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azaek
Copy link

@azaek azaek commented Jan 19, 2023

Exit animation weren't working properly due to 2 AnimatePresence wrap

@vercel
Copy link

vercel bot commented Jan 19, 2023

@azaek is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

@azaek azaek changed the title #16 Fixed the phone screen leaflet exit animation Fixed the phone screen leaflet exit animation Jan 19, 2023
@steven-tey
Copy link
Owner

Thanks for the PR! Just checking this out – it seems like it's still not working?

CleanShot.2023-01-19.at.11.00.05.mp4

@azaek
Copy link
Author

azaek commented Jan 19, 2023

Weird I have literally the same code in another project and it works 😶. I'm gonna look more

@azaek
Copy link
Author

azaek commented Jan 19, 2023

fm.mp4

image

@azaek
Copy link
Author

azaek commented Mar 11, 2023

Update on the issue: AnimatePresence doesn't trigger the exit animation if the dialog components are used from hooks. If you use the base dialog component without it works fine.

@steven-tey
Copy link
Owner

@azaek whoa interesting! So in this case you can't use the Leaflet component from within a hook? Sounds kinda odd – would it be a bug on Framer Motion's side?

@azaek
Copy link
Author

azaek commented Mar 14, 2023

Yea it's very odd. I guess it's from Framer Motion's side, I raised a bug issue there. Let's see

@steven-tey
Copy link
Owner

Awesome, thank you so much @azaek! Can you link to the issue here?

@azaek
Copy link
Author

azaek commented Mar 14, 2023

Sure, motiondivision/motion#2009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants