Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed you've been implementing components, I figured Bootstrap layouts might come in handy as well (though kobweb has some implementations for Columns and such, but not really equivalent to what BS offers).
So for this first layout, I picked
Container
which is fairly simple, yet widely used.I tried to be in line with the code-style of the project.
Implementation choices
Breakpoint
enum, as it is a framework-wide notion. This is of course debatable.OffcanvasBreakpoint
class. I don't know if it was forgotten or if you have plans with it, so I left it alone (though I feel it could benefit from the newly createdBreakpoint
class).Scope
This PR only includes the basic Container layout, not the Grid layout that can be added on it.