Accounts: For signup, login and password reset, username and password should be treated case insensitive #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sulting thumbnail needs to be saved as a PNG. For stephenmcd#1925
…el"]; Fixes stephenmcd#2054 due to Bleach version change
… and password reset forms. More unit test cases added for accounts to cover these cases. Fixes stephenmcd#2066
…der versions of Django won't support the form I'm using in the tests.
henri-hulski
approved these changes
Dec 24, 2023
molokov
commented
Feb 1, 2024
| @@ -429,12 +429,17 @@ def thumbnail( | |||
| pad_container = Image.new("RGBA", pad_size, padding_color) | |||
| pad_container.paste(image, (pad_left, pad_top)) | |||
| image = pad_container | |||
| # Make thumbnail a PNG - required if original isn't one | |||
There was a problem hiding this comment.
I think this change probably doesn't need to go back to main, I'm sure there's a better solution to changing a JPG's thumbnail to PNG (to allow for transparency background when using padding). Feel free to skip these lines on merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2066
My apologies that this branch contains other unrelated fixes, but some of these are required to run with the latest versions of Bleach/PIL and thus are part of my fork already.