Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise the latest TinyMCE library instead of older library #1896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Olorin92
Copy link

This fork attempts to implement the newer TinyMCE library and make it work with the existing Mezzanine implementation for the older (vulnerable) TinyMCE.

Light testing shows that this should still work for the editor - but I'm not sure of any other more wide-reaching effects.

Comments/suggestions are welcome!

@stephenmcd
Copy link
Owner

Thanks a lot for working on this. The functionality seems to work correctly in the admin as well as front-end editing. There are some styling issues in the admin, compare the two screenshots using the old and new versions:

Old:
screen shot 2018-10-16 at 2 54 51 pm

New:
screen shot 2018-10-16 at 2 55 03 pm

You can see the new editor blows out into the left-hand column where field names are listed.

Also the full-screen button fails badly both in the admin and front-end editing, in different ways for each.

@Olorin92
Copy link
Author

Great thanks for checking this - I figured someone else would now how to make it break!

I'll take a look at both of those things - just by eyeballing it it seems the newer TinyMCE has styling changes in that toolbar, so I suspect some of those changes are what's causing the weirdness.

Will commit changes once I fix those two things up.

@Olorin92
Copy link
Author

OK finally got the chance to start looking at this again - I can see what you're talking about with the full screen issue, but I'm not sure about the labels. For me the label just appears on top as normal:

image

Is this how it should look/different to what you're getting?

Fullscreen issue looks like the top of the editor sits underneath the top bar, so you can't undo the full screen without fiddling around. I'll see if there's an easy CSS change that prevents that from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants