Skip to content

fix: do not include empty values (e.g. ="") on boolean attributes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnjenkins merged 10 commits into from
Feb 15, 2026
Merged

fix: do not include empty values (e.g. ="") on boolean attributes #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c84d7c1
fix: adjust mock doc imports for v5
johnjenkins Feb 13, 2026
f850b13
Merge remote-tracking branch 'origin/main' into fix-cope-with-v5-env-…
johnjenkins Feb 13, 2026
93469ca
chore: remove for now
johnjenkins Feb 13, 2026
77cf834
fix: override chai globals in mock-docs
johnjenkins Feb 13, 2026
d2aa2f8
Merge remote-tracking branch 'origin/main' into fix-mock-doc-override…
johnjenkins Feb 13, 2026
ca22efe
fix: chai / mock-doc Event conflicts
johnjenkins Feb 13, 2026
dcacce9
Merge remote-tracking branch 'origin/main' into fix-event-conflict
johnjenkins Feb 13, 2026
22039de
Merge remote-tracking branch 'origin/main' into fix-boolean-attrs
johnjenkins Feb 15, 2026
57f7635
fix: do not include empty values (e.g. `=""`) on boolean attributes
johnjenkins Feb 15, 2026
51187df
chore:
johnjenkins Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/testing/html-serializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ function serializeElementWithShadow(
if (elem.attributes) {
for (let i = 0; i < elem.attributes.length; i++) {
const attr = elem.attributes[i];
html += ` ${attr.name}="${attr.value}"`;
// Boolean attributes (empty string value) should not have ="value"
if (attr.value === '') {
html += ` ${attr.name}`;
} else {
html += ` ${attr.name}="${attr.value}"`;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion test-project/src/components/my-button/__snapshots__/my-button-snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ exports[`my-button - snapshot tests > should match snapshot for card with nested
exports[`my-button - snapshot tests > should match snapshot for disabled button 1`] = `
<my-button class="hydrated">
<mock:shadow-root>
<button class="button button--primary button--medium" disabled="" type="button">
<button class="button button--primary button--medium" disabled type="button">
<slot></slot>
</button>
</mock:shadow-root>
Expand Down
2 changes: 1 addition & 1 deletion test-project/src/components/my-button/my-button-matchers.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('my-button - custom matchers', () => {
expect(root).toEqualHtml(`
<my-button class="hydrated">
<mock:shadow-root>
<button class="button button--primary button--medium" disabled="" type="button">
<button class="button button--primary button--medium" disabled type="button">
<slot></slot>
</button>
</mock:shadow-root>
Expand Down
16 changes: 8 additions & 8 deletions test-project/src/components/non-shadow/non-shadow-jsdom.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,23 @@ describe('non-shadow-component serialization', () => {
<non-shadow-component class="sc-non-shadow-component-h hydrated">
<div class="wrapper sc-non-shadow-component">
<div class="header sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb name="header" class="sc-non-shadow-component" hidden="">
<slot-fb name="header" class="sc-non-shadow-component" hidden>
Default Header
</slot-fb>
<span slot="header">
Custom Header
</span>
</div>
<div class="content sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb class="sc-non-shadow-component" hidden="">
<slot-fb class="sc-non-shadow-component" hidden>
Default Content
</slot-fb>
<p>
Custom Content
</p>
</div>
<div class="footer sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb name="footer" class="sc-non-shadow-component" hidden="">
<slot-fb name="footer" class="sc-non-shadow-component" hidden>
Default Footer
</slot-fb>
<span slot="footer">
Expand Down Expand Up @@ -88,7 +88,7 @@ describe('non-shadow-component serialization', () => {
<non-shadow-component class="sc-non-shadow-component-h hydrated">
<div class="wrapper sc-non-shadow-component">
<div class="header sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb name="header" class="sc-non-shadow-component" hidden="">
<slot-fb name="header" class="sc-non-shadow-component" hidden>
Default Header
</slot-fb>
<span slot="header">
Expand Down Expand Up @@ -137,7 +137,7 @@ describe('non-shadow-component serialization', () => {
</slot-fb>
</div>
<div class="content sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb class="sc-non-shadow-component" hidden="">
<slot-fb class="sc-non-shadow-component" hidden>
Default Content
</slot-fb>
<span>
Expand Down Expand Up @@ -207,7 +207,7 @@ describe('non-shadow-component serialization', () => {
<non-shadow-component class="sc-non-shadow-component-h hydrated">
<div class="wrapper sc-non-shadow-component">
<div class="header sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb name="header" class="sc-non-shadow-component" hidden="">
<slot-fb name="header" class="sc-non-shadow-component" hidden>
Default Header
</slot-fb>
<non-shadow-component slot="header" class="sc-non-shadow-component-h hydrated">
Expand All @@ -218,7 +218,7 @@ describe('non-shadow-component serialization', () => {
</slot-fb>
</div>
<div class="content sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb class="sc-non-shadow-component" hidden="">
<slot-fb class="sc-non-shadow-component" hidden>
Default Content
</slot-fb>
<span>
Expand All @@ -234,7 +234,7 @@ describe('non-shadow-component serialization', () => {
</non-shadow-component>
</div>
<div class="content sc-non-shadow-component sc-non-shadow-component-s">
<slot-fb class="sc-non-shadow-component" hidden="">
<slot-fb class="sc-non-shadow-component" hidden>
Default Content
</slot-fb>
<p>
Expand Down