[services][feat] #81: Add test for ingesting path payments #84
+131
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/services/ingest_test.go
Outdated
| @@ -215,3 +216,166 @@ func TestIngestPayments(t *testing.T) { | |||
| assert.Equal(t, payments[0].TransactionHash, "abcd") | |||
| }) | |||
| } | |||
|
|
|||
| func TestIngestPathPaymentsSend(t *testing.T) { | |||
There was a problem hiding this comment.
can you make this a unit test under the TestIngestPayments function? With a t.Run("op_pat_payment_send", func(t *testing.T) { ...} ? That way you can also reuse the same set up code
There was a problem hiding this comment.
Yup, good call. Updated in 90f7d32
internal/services/ingest_test.go
Outdated
| }) | ||
| } | ||
|
|
||
| func TestIngestPathPaymentsReceive(t *testing.T) { |
There was a problem hiding this comment.
Same as above. Can you make this a unit test under the TestIngestPayments function?
|
|
||
| t.Run("test_op_path_payment_send", func(t *testing.T) { | ||
| err := models.Account.Insert(context.Background(), srcAccount) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
nitpicking here but I don't really think you require this line. This is not a test to see if models are working. I'd replace it with _ := models.Account.Insert(context.Background(), srcAccount)
| Operations: []txnbuild.Operation{&pathPaymentOp}, | ||
| Preconditions: txnbuild.Preconditions{TimeBounds: txnbuild.NewTimeout(10)}, | ||
| }) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
same as above. This can be replaced with:
transaction, _ := txnbuild.NewTransaction(txnbuild.TransactionParams{
SourceAccount: &txnbuild.SimpleAccount{
AccountID: keypair.MustRandom().Address(),
},
Operations: []txnbuild.Operation{&pathPaymentOp},
Preconditions: txnbuild.Preconditions{TimeBounds: txnbuild.NewTimeout(10)},
})
|
|
||
| signer := keypair.MustRandom() | ||
| errSigner := models.Account.Insert(context.Background(), signer.Address()) | ||
| require.NoError(t, errSigner) |
| require.NoError(t, errSigner) | ||
|
|
||
| signedTx, err := transaction.Sign(network.TestNetworkPassphrase, signer) | ||
| require.NoError(t, err) |
| require.NoError(t, err) | ||
|
|
||
| txEnvXDR, err := signedTx.Base64() | ||
| require.NoError(t, err) |
|
|
||
| t.Run("test_op_path_payment_receive", func(t *testing.T) { | ||
| err := models.Account.Insert(context.Background(), srcAccount) | ||
| require.NoError(t, err) |
| Operations: []txnbuild.Operation{&pathPaymentOp}, | ||
| Preconditions: txnbuild.Preconditions{TimeBounds: txnbuild.NewTimeout(10)}, | ||
| }) | ||
| require.NoError(t, err) |
|
|
||
| signer := keypair.MustRandom() | ||
| errSigner := models.Account.Insert(context.Background(), signer.Address()) | ||
| require.NoError(t, errSigner) |
| require.NoError(t, errSigner) | ||
|
|
||
| signedTx, err := transaction.Sign(network.TestNetworkPassphrase, signer) | ||
| require.NoError(t, err) |
| require.NoError(t, err) | ||
|
|
||
| txEnvXDR, err := signedTx.Base64() | ||
| require.NoError(t, err) |
gouthamp-stellar
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
What
Add test for ingest of path payments
Why
Current test cases only cover regular payments
Known limitations
N/A
Issue that this PR addresses
#81
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release