Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic TSS #83

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Generic TSS #83

merged 5 commits into from
Dec 19, 2024

Conversation

gouthamp-stellar
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar commented Nov 26, 2024 •
edited by JakeUrban
Loading

What

Making TSS generic - work for all transactions. Implementation of the doc: https://docs.google.com/document/d/1MJ3iyiTbASJp8hq1cTJO_aHDtP3Ko7kpMnKqzjYhITE/edit?tab=t.0

Why

We need to make TSS work for all types of transactions and not just the disbursement use case

Known limitations

N/A

Issue that this PR addresses

resolves #79

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@gouthamp-stellar gouthamp-stellar requested a review from a team November 27, 2024 17:27
@aristidesstaffieri
Copy link
Contributor

Should this work for transactions that need a specific signer(s)?
If so maybe we could use an option to submit an already signed tx and only build it instead of build + sign it?

aristidesstaffieri
aristidesstaffieri reviewed Dec 2, 2024
View reviewed changes
internal/tss/utils/operation_builder_test.go
"github.com/stretchr/testify/assert"
)

func TestBuildOperations(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a case for t.Run("op_invoke_host_function"...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

aditya1702
aditya1702 requested changes Dec 4, 2024
View reviewed changes
internal/tss/utils/operation_builder_test.go
"github.com/stretchr/testify/assert"
)

func TestBuildOperations(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

aditya1702
aditya1702 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@aditya1702 aditya1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouthamp-stellar gouthamp-stellar merged commit 6124337 into main Dec 19, 2024
5 checks passed
@gouthamp-stellar gouthamp-stellar deleted the tss_all_transactions branch December 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristidesstaffieri aristidesstaffieri aristidesstaffieri approved these changes

@aditya1702 aditya1702 aditya1702 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TSS generic
3 participants
@gouthamp-stellar @aristidesstaffieri @aditya1702