Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic TSS #83

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Generic TSS #83

wants to merge 4 commits into from

Conversation

gouthamp-stellar
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar commented Nov 26, 2024

What

Making TSS generic - work for all transactions. Implementation of the doc: https://docs.google.com/document/d/1MJ3iyiTbASJp8hq1cTJO_aHDtP3Ko7kpMnKqzjYhITE/edit?tab=t.0

Why

We need to make TSS work for all types of transactions and not just the disbursement use case

Known limitations

N/A

Issue that this PR addresses

#79

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@gouthamp-stellar gouthamp-stellar requested a review from a team November 27, 2024 17:27
@aristidesstaffieri
Copy link

Should this work for transactions that need a specific signer(s)?
If so maybe we could use an option to submit an already signed tx and only build it instead of build + sign it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants