Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tss: Populate tss worker pools #49

Merged
merged 142 commits into from
Oct 23, 2024
Merged

tss: Populate tss worker pools #49

merged 142 commits into from
Oct 23, 2024

Conversation

gouthamp-stellar
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar commented Oct 3, 2024 •
edited
Loading

What

On a ticker, start a process that periodically resubmits transactions to the worker pools based on the transaction's current status. See https://docs.google.com/document/d/1xcX86-w8lwT_60flCuYBK9X9co-108-5X6D9e5epw0U/edit#heading=h.uqx8rvicq954

Why

We need to process transactions that are left in an intermediate state

Known limitations

N/A

Issue that this PR addresses

https://app.asana.com/0/1207947010297920/1208138733594336

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@gouthamp-stellar
tables and interfaces for TSS
a58d519
@gouthamp-stellar
TSS tables and the channel interface
9920f48
@gouthamp-stellar
remove empty lines
3f9f9f0
@gouthamp-stellar
update
373c71a
@gouthamp-stellar
adding semicolons
2de9898 
adding semicolons
@gouthamp-stellar
moving all migrations to one file
c0f9d32
@gouthamp-stellar
make hash primary key instead of xdr
a9cf4e3
@gouthamp-stellar
missing ,
6fc0dc2
@gouthamp-stellar
remove the index on try_transaction_xdr and add column/index on try_t…
fb807aa 
…ransaction_hash

...also remove outgoing/incoming_status and have one status column
@gouthamp-stellar
Squashed commit of the following:
f8c261b 
commit fb807aa
Author: gouthamp-stellar <[email protected]>
Date:   Tue Sep 3 10:28:49 2024 -0700

    remove the index on try_transaction_xdr and add column/index on try_transaction_hash

    ...also remove outgoing/incoming_status and have one status column

commit 6fc0dc2
Author: gouthamp-stellar <[email protected]>
Date:   Tue Sep 3 08:58:46 2024 -0700

    missing ,

commit a9cf4e3
Author: gouthamp-stellar <[email protected]>
Date:   Tue Sep 3 01:55:23 2024 -0700

    make hash primary key instead of xdr

commit c0f9d32
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 15:18:27 2024 -0700

    moving all migrations to one file

commit 2de9898
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 15:16:53 2024 -0700

    adding semicolons

    adding semicolons

commit 373c71a
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 15:12:24 2024 -0700

    update

commit 3f9f9f0
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 15:12:00 2024 -0700

    remove empty lines

commit 9920f48
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 15:06:40 2024 -0700

    TSS tables and the channel interface

commit a58d519
Author: gouthamp-stellar <[email protected]>
Date:   Fri Aug 30 10:55:22 2024 -0700

    tables and interfaces for TSS
@gouthamp-stellar
commit #2
d774f2a
@gouthamp-stellar
changing from RpcIngestTxResponse -> RpcGetIngestTxResponse
6b04d62
@gouthamp-stellar
Merge branch 'tss_tables_interfaces' into transaction_module
f2fefef
@gouthamp-stellar
latest changes
b441a31
@gouthamp-stellar
add tests for ValidateOptions
02c7de3
@gouthamp-stellar
changes based on comments
f9a5611
@gouthamp-stellar
Merge branch 'main' into tss_tables_interfaces
32bd6ce
@gouthamp-stellar
Merge branch 'tss_tables_interfaces' into transaction_module
5c7db27
@gouthamp-stellar
latest changes based on changes to interface
c3e8de9
@gouthamp-stellar
string -> RPCTXStatus
82b12fb
@gouthamp-stellar
Merge branch 'tss_tables_interfaces' into transaction_module
9a9c9be
@gouthamp-stellar
adding a transaction_builder.go which takes a list of operation xdrs …
0662da9 
…and builds a transaction out of it
@gouthamp-stellar
moving transaction_service to the utils dir
8f76d61
@gouthamp-stellar
upper case Channel methods
456b71f
@gouthamp-stellar
Merge branch 'tss_tables_interfaces' into transaction_module
7974aa9
@gouthamp-stellar
latest changes
5bdf8f2
@gouthamp-stellar
p.txService.NetworkPassPhrase()
3890bfe
@gouthamp-stellar
last commit before writing unit tests
e87c6d6
@gouthamp-stellar
Making the transaction service more injectible and adding fields to t…
c1d3786 
…he Payload
@gouthamp-stellar
typo
01ed3eb
CaioTeixeira95
CaioTeixeira95 reviewed Oct 14, 2024
View reviewed changes
internal/serve/serve.go Outdated Show resolved Hide resolved
internal/serve/serve.go Show resolved Hide resolved
internal/tss/router/router.go Outdated Show resolved Hide resolved
internal/tss/router/router_test.go Outdated Show resolved Hide resolved
internal/tss/channels/webhook_channel_test.go Outdated Show resolved Hide resolved
internal/services/ingest_test.go Show resolved Hide resolved
internal/tss/services/pool_populator.go Outdated Show resolved Hide resolved
internal/tss/services/pool_populator.go Outdated Show resolved Hide resolved
CaioTeixeira95
CaioTeixeira95 reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments about some flows. Let me know what you think.

internal/db/migrations/2024-10-14.0-alter_tss_transaction_tries.sql Outdated Show resolved Hide resolved
internal/db/migrations/2024-10-14.0-alter_tss_transaction_tries.sql Outdated Show resolved Hide resolved
internal/serve/serve.go Outdated Show resolved Hide resolved
internal/tss/services/pool_populator.go Outdated Show resolved Hide resolved
internal/tss/services/transaction_manager_test.go Show resolved Hide resolved
internal/tss/store/store.go Outdated Show resolved Hide resolved
CaioTeixeira95
CaioTeixeira95 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for all the changes and patient!

Base automatically changed from rpc_ingestor to main October 23, 2024 20:05
@gouthamp-stellar gouthamp-stellar merged commit dd63a2b into main Oct 23, 2024
5 checks passed
@gouthamp-stellar gouthamp-stellar deleted the populate_pools branch October 23, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaioTeixeira95 CaioTeixeira95 CaioTeixeira95 approved these changes

@daniel-burghardt daniel-burghardt Awaiting requested review from daniel-burghardt

@gsoarescosta gsoarescosta Awaiting requested review from gsoarescosta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouthamp-stellar @CaioTeixeira95