Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: rpc service #45

Merged
merged 7 commits into from
Sep 26, 2024
Merged

services: rpc service #45

merged 7 commits into from
Sep 26, 2024

Conversation

daniel-burghardt
Copy link
Member

@daniel-burghardt daniel-burghardt commented Sep 25, 2024

What

Creates a new RPC service, extracting the logic from the TSS package into a more general one to be available and used across the application.

Why

The Ingest Service for the new Balances Ingestion feature will also require RPC communication, therefore the RPC functions are being extracted into its own service.

Known limitations

N/A

Issue that this PR addresses

[Wallet Backend] Refactor RPC code into a separate service

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@gouthamp-stellar
Copy link
Contributor

This mostly looks good to me aside from the tiny comments, let me know when you have the tests running and I'll take another look

@daniel-burghardt daniel-burghardt changed the title ingest: account balances tracking services: rpc service Sep 26, 2024
@daniel-burghardt daniel-burghardt marked this pull request as ready for review September 26, 2024 15:29
@daniel-burghardt daniel-burghardt self-assigned this Sep 26, 2024
@daniel-burghardt daniel-burghardt merged commit e9cdaa2 into main Sep 26, 2024
5 checks passed
@daniel-burghardt daniel-burghardt deleted the balance-ingestion branch September 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants