Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httphandler: limit param on payments capped at 200 #41

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

daniel-burghardt
Copy link
Member

What

Adds a cap of 200 to the limit parameter of the GET /payments endpoint.

Why

So that unreasonably high limits are not allowed which could drain too many resources of the app.

Known limitations

N/A

Issue that this PR addresses

[Wallet Backend] Add a limit to the page size parameter in GET /payments

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@daniel-burghardt daniel-burghardt merged commit 1f76780 into main Sep 19, 2024
5 checks passed
@daniel-burghardt daniel-burghardt deleted the payments-limit branch September 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants