ingest: asset_types and memo_type columns added #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaioTeixeira95
approved these changes
Jul 1, 2024
| @@ -20,7 +20,7 @@ CREATE TABLE ingest_payments ( | |||
| dest_asset_issuer text NOT NULL, | |||
| dest_amount bigint NOT NULL, | |||
| created_at timestamp with time zone NOT NULL, | |||
| memo text, | |||
| memo text NULL, | |||
There was a problem hiding this comment.
Now that we've got a deployed version, we should be careful about modifying the migrations.
There was a problem hiding this comment.
For sure! But in this case it should be safe, since this is just making the default value explicit to match the pattern in the other migrations.
Comment on lines
+4
to
+5
| ADD COLUMN src_asset_type text NOT NULL, | ||
| ADD COLUMN dest_asset_type text NOT NULL, |
There was a problem hiding this comment.
We are safe, but if we have entries in this table this migration will fail.
There was a problem hiding this comment.
Indeed! I also tried explaining that in the Known limitations section.
| DestAmount: 50, | ||
| CreatedAt: time.Date(2024, 5, 28, 11, 0, 0, 0, time.UTC), | ||
| Memo: &expectedMemo, | ||
| Memo: utils.PointOf("memo_test"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds three columns to the
ingest_paymentstable, to be persisted when running ingestion.Columns:
src_asset_type,dest_asset_typeandmemo_type.Why
These are relevant columns to the Vibrant wallet and potentially to other wallets as well.
Known limitations
If ingestion had been running on any instance prior to this merge and there are any records in the
ingest_paymentstable, those must be wiped before the migration can run.Since the Wallet Backend is in development phase and there are no instances running yet, this shouldn't be a problem.
Issue that this PR addresses
[Wallet Backend] Add new columns to payments ingestion
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release