cmd: migrate command #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/migrate.go
Outdated
Comment on lines
34
to
39
| PersistentPreRun: func(_ *cobra.Command, _ []string) { | ||
| cfgOpts.Require() | ||
| if err := cfgOpts.SetValues(); err != nil { | ||
| log.Fatalf("Error setting values of config options: %s", err.Error()) | ||
| } | ||
| }, |
There was a problem hiding this comment.
Before you write too many CLI commands, there's a good practice you should adopt here.
These commands have counterparts that return errors:
PersistentPreRun->PersistentPreRunERun->RunE- ...
Instead of logging with Fatal, it's better to return an error and log + Panic in the root caller. It's easier to debug and to write tests for it.
log.Fatalf calls os.Exit(0), which terminates the program without very good feedback.
There was a problem hiding this comment.
Thanks for raising this @marcelosalloum! Great suggestion.
I'll add to this one and refactor the other two commands we already have in place. 👍
CaioTeixeira95
approved these changes
Jun 7, 2024
| @@ -24,3 +24,8 @@ func Open(t *testing.T) *dbtest.DB { | |||
|
|
|||
| return db | |||
| } | |||
|
|
|||
| func OpenWithoutMigrations(t *testing.T) *dbtest.DB { | |||
What Adds the Dockerfile for building the API's Docker image. A Makefile is also added to make the CI/CD later easier. The docker-compose is also changed to use the new Dockerfile and run the API more easily. Why Building the system's Docker image.
…nto migrate-command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the
migrate up/downcommand.Why
For applying the database migration. This is a required component for the CI/CD setup.
Known limitations
N/A
Issue that this PR addresses
[Wallet Backend] Implement migrate command
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release