signing: add signature client #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaioTeixeira95
requested review from
marcelosalloum,
marwen-abid and
daniel-burghardt
CaioTeixeira95
force-pushed
the
env-signature-client
branch
from
ab1f1a5
to
0893a13
Compare
CaioTeixeira95
force-pushed
the
env-signature-client
branch
from
0893a13
to
5f03996
Compare
marcelosalloum
approved these changes
Jun 5, 2024
go.sum
Outdated
There was a problem hiding this comment.
I'm confused in why go.mod was not updated and go.sum was. Did you execute go mod tidy here? Is this something that should have been done in a previous PR?
There was a problem hiding this comment.
I'm confused too. These PRs were split into 3, but I don't know why it appeared on this PR. May I fix it in another PR that only cleans up the dependencies? I think it would be easier.
There was a problem hiding this comment.
Since you're merging this into the validators branch (and not develop or main), this should be fine as long as @daniel-burghardt agrees with it.
There was a problem hiding this comment.
Since this is now pointing to main shall we just run a go mod tidy before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the
SignatureClientinterface and theEnvSignatureClientwhich implements theSignatureClientinterface. It receives a Stellar Private Key from the environment.Why
This layer handles the Stellar transaction signature.
Known limitations
N/A
Issue that this PR addresses
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release