Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use fmt for error wrapping #12

Merged
merged 2 commits into from
May 20, 2024
Merged

all: use fmt for error wrapping #12

merged 2 commits into from
May 20, 2024

Conversation

CaioTeixeira95
Copy link
Contributor

What

Use the fmt package for error wrapping.

Why

The third-party errors package is unnecessary because we can now use the standard library.

Known limitations

N/A

Issue that this PR addresses

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@CaioTeixeira95 CaioTeixeira95 self-assigned this May 17, 2024
@CaioTeixeira95 CaioTeixeira95 changed the title all: use fmt to error wrapping all: use fmt for error wrapping May 17, 2024
Copy link
Member

@daniel-burghardt daniel-burghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Minus one dependency. 🚀

@CaioTeixeira95 CaioTeixeira95 merged commit db5b9b0 into main May 20, 2024
5 checks passed
@CaioTeixeira95 CaioTeixeira95 deleted the fmt-error-wrapping branch May 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants