changes based on comments

cmd/ingest.go

@@ -56,7 +56,6 @@ func (c *ingestCmd) Command() *cobra.Command {
 		Use:   "ingest",
 		Short: "Run Ingestion service",
 		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
-			// SET UP WEBHOOK CHANNEL HERE
 			if err := cfgOpts.RequireE(); err != nil {
 				return fmt.Errorf("requiring values of config options: %w", err)
 			}

internal/services/ingest.go

@@ -152,7 +152,6 @@ func (m *ingestService) ingestPayments(ctx context.Context, ledgerTransactions [
 			if txMemo != nil {
 				*txMemo = utils.SanitizeUTF8(*txMemo)
 			}
-			txEnvelopeXDR.SourceAccount()
 			for idx, op := range txEnvelopeXDR.Operations() {
 				opIdx := idx + 1
 

internal/services/ingest_test.go

@@ -55,7 +55,7 @@ func TestGetLedgerTransactions(t *testing.T) {
 		txns, err := ingestService.GetLedgerTransactions(1)
 		assert.Equal(t, 1, len(txns))
 		assert.Equal(t, txns[0].Hash, "hash1")
-		assert.Empty(t, err)
+		assert.NoError(t, err)
 	})
 
 	t.Run("ledger_transactions_split_between_multiple_gettransactions_calls", func(t *testing.T) {
@@ -105,7 +105,7 @@ func TestGetLedgerTransactions(t *testing.T) {
 		assert.Equal(t, txns[0].Hash, "hash1")
 		assert.Equal(t, txns[1].Hash, "hash2")
 		assert.Equal(t, txns[2].Hash, "hash3")
-		assert.Empty(t, err)
+		assert.NoError(t, err)
 	})
 
 }
@@ -150,7 +150,7 @@ func TestProcessTSSTransactions(t *testing.T) {
 			Once()
 
 		err := ingestService.processTSSTransactions(context.Background(), transactions)
-		assert.Empty(t, err)
+		assert.NoError(t, err)
 
 		updatedTX, _ := tssStore.GetTransaction(context.Background(), "hash")
 		assert.Equal(t, string(entities.SuccessStatus), updatedTX.Status)

internal/services/rpc_service.go

@@ -58,7 +58,7 @@ func (r *rpcService) GetTransaction(transactionHash string) (entities.RPCGetTran
 
 func (r *rpcService) GetTransactions(startLedger int64, startCursor string, limit int) (entities.RPCGetTransactionsResult, error) {
 	if limit > PageLimit {
-		return entities.RPCGetTransactionsResult{}, fmt.Errorf("limit cannot exceed")
+		return entities.RPCGetTransactionsResult{}, fmt.Errorf("limit cannot exceed %d", PageLimit)
 	}
 	params := entities.RPCParams{}
 	if startCursor != "" {

internal/tss/router/router.go

@@ -51,7 +51,7 @@ func (r *router) Route(payload tss.Payload) error {
 					channel = r.ErrorJitterChannel
 				} else if slices.Contains(tss.NonJitterErrorCodes, payload.RpcSubmitTxResponse.Code.TxResultCode) {
 					channel = r.ErrorNonJitterChannel
-				} else if slices.Contains(tss.FinalErrorCodes, payload.RpcSubmitTxResponse.Code.TxResultCode) {
+				} else if slices.Contains(tss.FinalCodes, payload.RpcSubmitTxResponse.Code.TxResultCode) {
 					channel = r.WebhookChannel
 				}
 			}

internal/tss/router/router_test.go

@@ -97,7 +97,7 @@ func TestRouter(t *testing.T) {
 		}
 	})
 	t.Run("status_error_routes_to_webhook_channel", func(t *testing.T) {
-		for _, code := range tss.FinalErrorCodes {
+		for _, code := range tss.FinalCodes {
 			payload := tss.Payload{
 				RpcSubmitTxResponse: tss.RPCSendTxResponse{
 					Status: tss.RPCTXStatus{
@@ -123,7 +123,7 @@ func TestRouter(t *testing.T) {
 			RpcGetIngestTxResponse: tss.RPCGetIngestTxResponse{
 				Status: entities.SuccessStatus,
 				Code: tss.RPCTXCode{
-					TxResultCode: tss.FinalErrorCodes[0],
+					TxResultCode: tss.FinalCodes[0],
 				},
 			},
 		}

internal/tss/types.go

@@ -93,7 +93,7 @@ func (c RPCTXCode) Code() int {
 	return int(c.TxResultCode)
 }
 
-var FinalErrorCodes = []xdr.TransactionResultCode{
+var FinalCodes = []xdr.TransactionResultCode{
 	xdr.TransactionResultCodeTxSuccess,
 	xdr.TransactionResultCodeTxFailed,
 	xdr.TransactionResultCodeTxMissingOperation,

internal/utils/ingestion_utils.go

@@ -62,7 +62,6 @@ func SourceAccount(op xdr.Operation, txEnvelope xdr.TransactionEnvelope) string
 	if account != nil {
 		return account.ToAccountId().Address()
 	}
-	txEnvelope.SourceAccount()
 	return txEnvelope.SourceAccount().ToAccountId().Address()
 }