-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Archive merge into Cold Archive #4530
Draft
SirTyson
wants to merge
25
commits into
stellar:master
Choose a base branch
from
SirTyson:hot-archive-condense
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolves #4396
When the HotArchive BucketList becomes full, it needs to be merged into a single ColdArchive Bucket. This bucket will be used to initialize the ColdArchive BucketList that produces the root merkle hash for the given archival trie.
This PR adds functionality to merge a completed HotArchive into a single ColdArchive Bucket. For simplicty, this is not done using the
FutureBucket
interface. Due to this, we can not pick up in-progress merges across node restarts. If a merge is not completed and the node restarts, the node will have to restart the merge. However, if a node finishes the merge then restarts, it will pick up the finished bucket on restart. I think for now this is fine. The HotArchive BucketList will be small such that merges are quick. If this is an issue, it can always be addressed later.Opening as a draft until #4403 is merged.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)