Karthik/5614/generic offers parsing #5531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikiyer56
commented
Nov 15, 2024
| } | ||
| } | ||
|
|
||
| func ProcessOffer(change ingest.Change) OfferEvent { |
There was a problem hiding this comment.
This ProcessOffer has been pulled out into the top level /ingest package.
now horizon and stellar-etl can leverage this ProcessOffer function and thus eliminate the code duplication.
Further down in this PR in offer_processor.go, I have updated the horizon code to use this common function
next step: make stellar-etl use this ProcesOffer function here Cc: @chowbao
tamirms
reviewed
Nov 18, 2024
| ) | ||
|
|
||
| // Base struct with common fields for all offer events. | ||
| type OfferEventData struct { |
There was a problem hiding this comment.
I think it would be better to just use xdr.OfferEntry instead of this because it contains the same data so there is no need to introduce another struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]