support/http - Added default WriteTimeout of 30s to HTTP server #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Thanks for the PR! I think it'd be worthwhile to discuss this in the team meeting tomorrow because we have a lot of existing timeouts and this one needs to be bigger than all of them. For example, we kill DB requests after 10s and web requests after 30s, I think? So it's possible that this timeout needs to be higher, e.g. 45s. And others might have more thoughts. Can you add an agenda item?
| @@ -25,7 +25,7 @@ func TestRun_setupDefault(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, defaultShutdownGracePeriod, srv.Timeout) | |||
| assert.Equal(t, defaultReadTimeout, srv.ReadTimeout) | |||
| assert.Equal(t, time.Duration(0), srv.WriteTimeout) | |||
| assert.Equal(t, defaultWriteTimeout, srv.WriteTimeout) | |||
There was a problem hiding this comment.
This isn't wrong, but it also doesn't verify that for a non-zero config value, the same value is being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue for full context.
30 seconds seems like a reasonable default to account for large payloads and network congestion.