feat(charts): update deployment to include serviceAccountName#410
Open
dchien234 wants to merge 1 commit intostefanprodan:masterfrom
Open
feat(charts): update deployment to include serviceAccountName#410dchien234 wants to merge 1 commit intostefanprodan:masterfrom
dchien234 wants to merge 1 commit intostefanprodan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{- if .Values.serviceAccount.enabled }}.spec.template.spec.serviceAccountName, 2 possible values for this:{{- if .Values.serviceAccount.name }}then use this.Values.serviceAccount.namedefault(thisServiceAccountis always there)This is to solve the use case where you have an existing
ServiceAccountand want to use that (for e.g. Vault service account to pull secrets), instead of thedefault. But the conditional check{{- if .Values.serviceAccount.enabled }}will remove that capability.