Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct control additions #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cheewee2000
Copy link

I added

-keyboard control of the gantry (with shift for finer movement). It works even when you're not in the direct control tab (not sure if that's good or bad)
-cursor display on the cutting area window
-text area to enter the 0,0 position
-a button to set the current position as 0,0

that's all! feel free to add it into your branch or not.

One thing i noticed is when you click on the cutting area to set 0,0, when you then push 0,0 to go to the origin, the gantry moves a little. I suspect it's because of floats vs ints, but I couldn't figure out where the difference was in the code.

keyboard control of gantry
set current location as 0,0 button (and enter key)
display gantry position on cutting area window
text box to enter desired 0,0 position
@stefanix
Copy link
Owner

Hi cheewee, I looked through your list of addition. Most of them I find useful but would have to be implemented differently to be reliable. I have added some of them as issues to be added to the master at a later time, after we get some prerequesits in.

keyboard

Lasaurapp currently does not check if a job is already running. This means if you inadvertently press the arrow keys during a job it will lead to unexpected behavior at the end of the job. The right way of doing this is to have the firmware report if a job is processing and reject new command being send to the queue until finished.

cursor display and button to set current to 0,0

These too should be implemented in a way to use actual location data that is reported from the hardware. Otherwise they get out of sync easily and the feedback will be more misleading than helpful. We are working on this but first need to extensively test if there is some performance hit on the hardware side from replying each line with a location. I think this shouldn't be a problem just need to move step-by-step.

slight movement when moving to 0,0 after setting 0,0

Not exactly sure why. Maybe it's because moving to a pos and then setting it to 0,0 are two clicks. Shift-click does not set the current pos to 0,0 but the actual position where you clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants