Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to mount tasks & related docs #169

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

tigattack
Copy link
Contributor

  • Define more relevant loop labels for mount tasks
  • Document rclone_mkdir

@stefangweichinger
Copy link
Owner

sorry for being so late here. busy times

@stefangweichinger
Copy link
Owner

quick look: ok to me ... but the molecule-tests don't test this, right?

Shouldn't we maybe add some test(s) for that also?

@tigattack
Copy link
Contributor Author

It certainly wouldn't hurt. I suppose it would need a virtual remote (such as local) to be implemented in the test to use/test the rclone_mkdir functionality.

@stefangweichinger
Copy link
Owner

Sounds to be rather complicated. local would be a local directory in the target machine (in terms of testing here: target docker container)? hm, that might be possible to realize.

I am not sure if it's necessary or goes beyond the scope here.

@tigattack
Copy link
Contributor Author

Given the simplicity of the implementation, I'd personally be happy without a test in this case.

I think if we were to test this, it would open the door to test many other configurable/non-default aspects of the role. While that certainly wouldn't be a bad thing, I think this would fall rather low in the list of priorities if we were to add further tests.

@stefangweichinger
Copy link
Owner

I agree and merge this ...

@stefangweichinger stefangweichinger merged commit 1678c2b into stefangweichinger:main Nov 15, 2024
30 checks passed
@stefangweichinger
Copy link
Owner

I tagged 0.2.1 now ... should result in a release to galaxy.
If #161 is correct etc

@tigattack tigattack deleted the nice_loops branch November 15, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants