Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure local mount path exists #168

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

tigattack
Copy link
Contributor

Adds a task to ensure the local mount path exists with optionally configurable mode, owner, and group.

Adds a task to ensure the local mount path exists with optionally configurable mode, owner, and group.
@tigattack
Copy link
Contributor Author

Should this new task respect the state of rclone_mkdir? I think not, since I can't envisage a scenario where a user would not wish for the local mount path to exist, but can imagine some users may wish to be more stringent when it comes to performing actions on the remote filesystem (hence why rclone_mkdir exists, I suppose).

Open to thoughts/discussion.

@stefangweichinger
Copy link
Owner

@tigattack thanks for your PRs. Pls allow me some time until I can look into and think about them. Busy days here ;-)

@stefangweichinger
Copy link
Owner

sorry for being so late here. busy times

@stefangweichinger
Copy link
Owner

I have no specific opinion here. I like the enhancement and tend to merge it to get the PR closed at last (my fault).
I assume you, @tigattack use your patched version since filing this PR ... so it's "tested" already.

A new release to galaxy needs a tag anyway, I might wait with tagging until I am through the other PRs.

@tigattack
Copy link
Contributor Author

No problem, I understand! Indeed, I have been using my patch and it seems to be working great.

@stefangweichinger stefangweichinger merged commit c063fdd into stefangweichinger:main Nov 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants