-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: add archlinux test-scenario as platform #164
Conversation
I don't know yet how to target that platform in the tests now ... Locally I can do a |
I think this comment can be resolved here. |
I agree .. might try that before leaving house for the weekend ... thanks for the pointer |
I don't understand why this step is passing without updating cache here and failing for me locally.... Do you think we should still add it? |
looks good! @hkcomori pls check if that archlinux testing is ok in the gh actions now. |
.github/workflows/molecule.yml
Outdated
with: | ||
image: carlodepieri/docker-archlinux-ansible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to remove this since it is configured in platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, that was just some random try yesterday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're at it: I think galaxy_release.yml
in the workflows could be removed also. Was a try back then, the task is done within molecule.yml
. Agree?
looks good to me. pls let's wait a bit before merging, I 'd like to review things once again on monday or so. ok? |
Yes, I agree. |
Yes. I noticed that the docker image the archlinux tests use is a bit old, is that true? Does it matter? I think I might merge #164 right now before leaving for today. #162 maybe tomorrow. Just being cautious. |
new draft for getting the testing of arch linux into the default scenario
Tests OK locally here, I assume gh-actions to fail at first (workflow might need adjustments)