Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add archlinux test-scenario as platform #164

Merged
merged 8 commits into from
Aug 3, 2024

Conversation

stefangweichinger
Copy link
Owner

new draft for getting the testing of arch linux into the default scenario

Tests OK locally here, I assume gh-actions to fail at first (workflow might need adjustments)

@stefangweichinger
Copy link
Owner Author

I don't know yet how to target that platform in the tests now ...

Locally I can do a molecule test --platform-name rclone-archlinux now successfully (which is nice IMO)

@gamezftw
Copy link
Contributor

gamezftw commented Aug 2, 2024

Take a look at this link
We can use MOLECULE_PLATFORM_NAME env variable to pass name of the platform.

Or here we can override command with command: "test --platform rclone-archlinux".

I think env variable one would be nicer, what do you think?

@gamezftw
Copy link
Contributor

gamezftw commented Aug 3, 2024

I think this comment can be resolved here.

@stefangweichinger
Copy link
Owner Author

Take a look at this link We can use MOLECULE_PLATFORM_NAME env variable to pass name of the platform.

Or here we can override command with command: "test --platform rclone-archlinux".

I think env variable one would be nicer, what do you think?

I agree .. might try that before leaving house for the weekend ... thanks for the pointer

@gamezftw
Copy link
Contributor

gamezftw commented Aug 3, 2024

I don't understand why this step is passing without updating cache here and failing for me locally.... Do you think we should still add it?

@stefangweichinger
Copy link
Owner Author

looks good! @hkcomori pls check if that archlinux testing is ok in the gh actions now.

with:
image: carlodepieri/docker-archlinux-ansible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to remove this since it is configured in platform.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, that was just some random try yesterday

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're at it: I think galaxy_release.yml in the workflows could be removed also. Was a try back then, the task is done within molecule.yml. Agree?

@hkcomori
Copy link
Contributor

hkcomori commented Aug 3, 2024

I rebase #162 to #164, the gh action is successful in #162.

@stefangweichinger
Copy link
Owner Author

looks good to me. pls let's wait a bit before merging, I 'd like to review things once again on monday or so. ok?
#164 and the changes to one scenario only, with 2 platforms, looks like a good solution to me.
Now we have to only maintain one molecule-scenario. Agree?

@hkcomori
Copy link
Contributor

hkcomori commented Aug 3, 2024

Yes, I agree.
In my opinion, one molecule-scenario is best unless there is a very special reason.

@stefangweichinger
Copy link
Owner Author

Yes, I agree. In my opinion, one molecule-scenario is best unless there is a very special reason.

Yes. I noticed that the docker image the archlinux tests use is a bit old, is that true? Does it matter?

I think I might merge #164 right now before leaving for today. #162 maybe tomorrow. Just being cautious.

@stefangweichinger stefangweichinger merged commit 1341e60 into main Aug 3, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants