add feature rclone mount

[babidi34]

No description provided.

[stefangweichinger]

@babidi34 Thanks for the PR, will look into it in more detail asap.
Would you mind adding some description or some lines of HOWTO for the main README? Thanks.

[stefangweichinger]

I assume that should be "activate"

[babidi34]

@babidi34 Thanks for the PR, will look into it in more detail asap. Would you mind adding some description or some lines of HOWTO for the main README? Thanks.

Thanks for the feedback! I've added the README update.

[stefangweichinger]

Thanks for the feedback! I've added the README update.

looks good to me, thanks. I assume there is no way of a specific test of this with molecule.
I will run the existing test, and proceed to merging later this week or so.

[stefangweichinger]

some linting issues ... @babidi34 would you have a look?

[babidi34]

yes I saw I will try to correct my PR this weekend Le mar. 2 avr. 2024 à 09:38, Stefan G. Weichinger ***@***.***> a écrit :

…

some linting issues ... @babidi34 <https://github.com/babidi34> would you have a look? — Reply to this email directly, view it on GitHub <#148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGCG67TQCD6UKYR3FXDVWWDY3JN5VAVCNFSM6AAAAABFOEMOQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGI4DKMJVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[stefangweichinger]

yes I saw I will try to correct my PR this weekend

Fixed most of the issues locally, but can't push to your branch ... sure.

The missing issues:

 ansible-lint .
WARNING  Listing 3 violation(s) that are fatal
command-instead-of-module: systemctl used in place of systemd module
handlers/main.yml:6 Task/Handler: Reload and restart rclone-mount services

no-changed-when: Commands should not change things if nothing needs doing.
handlers/main.yml:6 Task/Handler: Reload and restart rclone-mount services

no-changed-when: Commands should not change things if nothing needs doing.
tasks/mount.yml:3 Task/Handler: Create directory backup on the cloud

I might look closer asap, but this week is quite busy already. And I'd prefer state-of-the-art ansible code ;-)

[babidi34]

I fixed lint error, normaly it's ok now

[stefangweichinger]

I fixed lint error, normaly it's ok now

linting seems ok now, thanks. Patches look good at a first glance! nice work

[babidi34]

Thanks Le mer. 10 avr. 2024, 16:40, Stefan G. Weichinger ***@***.***> a écrit :

…

I fixed lint error, normaly it's ok now linting seems ok now, thanks. Patches look good at a first glance! nice work — Reply to this email directly, view it on GitHub <#148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGCG67QRH4TB5GTOYIUQCSDY4VFN3AVCNFSM6AAAAABFOEMOQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXG42DEOJUG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[stefangweichinger]

@babidi34 pls give me some time for the merge. This will trigger a minor release update, and I always struggle with getting the tags right. The automatism doesn't work for me.

[stefangweichinger]

You know that this does not enable and restart the services? It's not the same behavior.

[stefangweichinger]

@babidi34 Your PR was merged and is in the release 0.1.5 here:

https://galaxy.ansible.com/ui/standalone/roles/stefangweichinger/ansible_rclone/versions/

thanks for your contribution!

[babidi34]

Thank you for creating this role. It simplifies my life in managing backups of my machines.

[stefangweichinger]

Thank you for creating this role. It simplifies my life in managing backups of my machines.

You're welcome. It started as a small learning project ...