Skip to content

Commit

Permalink
do not run release job on pr
Browse files Browse the repository at this point in the history
add conditional to `release` job to not run on pull_request
fix `tags-ignore` syntax
do not trigger pr workflow on changes to `README.md`
add `test-archlinux` to needs on `release` job
  • Loading branch information
gamezftw authored and stefangweichinger committed Jul 18, 2024
1 parent 628f902 commit 35a66e1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/molecule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ name: Ansible Molecule

on: # yamllint disable-line rule:truthy
push:
tags_ignore:
tags-ignore:
- '*'
paths-ignore:
- 'README.md'
pull_request:
branches:
- main
paths-ignore:
- 'README.md'
schedule:
- cron: '15 8 8 * *'

Expand Down Expand Up @@ -96,8 +98,10 @@ jobs:
with:
scenario: ${{ matrix.scenario }}
release:
if: github.ref == 'refs/heads/main'
needs:
- test
- test-archlinux
runs-on: ubuntu-latest
steps:
- name: Release to ansible galaxy
Expand Down

1 comment on commit 35a66e1

@stefangweichinger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "tags-ignore" is too much here: new tags should always trigger the workflow because the tags are used to mark a new release to galaxy.
We might remove that clause completely, I am not sure why I put it there originally. I assume it could be used to ignore tags like "test-*" or so.

Please sign in to comment.