remove the unnecessary checking

steelgeek091 · Apr 23, 2024 · 443a656 · 443a656
1 parent 7799325
commit 443a656
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/crates/rooch-rpc-server/src/server/rooch_server.rs b/crates/rooch-rpc-server/src/server/rooch_server.rs
@@ -49,7 +49,7 @@ use std::cmp::min;
 use std::str::FromStr;
 use tracing::info;
 
-const MAX_RESULT_AMOUNT: u64 = 10000000;
+const MAX_RESULT_AMOUNT: u64 = 10000;
 
 pub struct RoochServer {
     rpc_service: RpcService,
@@ -406,7 +406,7 @@ impl RoochAPIServer for RoochServer {
                 ))?;
             if gaps > MAX_RESULT_AMOUNT {
                 return Err(jsonrpsee::core::Error::Custom(
-                    "end value is overflow".to_string(),
+                    "amount of the result is too large".to_string(),
                 ));
             }
 
@@ -433,7 +433,7 @@ impl RoochAPIServer for RoochServer {
                 ))?;
             if gaps > MAX_RESULT_AMOUNT {
                 return Err(jsonrpsee::core::Error::Custom(
-                    "end value is overflow".to_string(),
+                    "amount of the result is too large".to_string(),
                 ));
             }
 

diff --git a/crates/rooch-store/src/transaction_store/mod.rs b/crates/rooch-store/src/transaction_store/mod.rs
@@ -8,8 +8,6 @@ use raw_store::CodecKVStore;
 use raw_store::{derive_store, StoreInstance};
 use rooch_types::transaction::LedgerTransaction;
 
-const MAX_RESULT_AMOUNT: u64 = 10000000;
-
 derive_store!(
     LedgerTransactionStore,
     H256,
@@ -37,14 +35,6 @@ pub trait TransactionStore {
         let start = cursor.unwrap_or(0);
         let end = start + limit;
 
-        let gaps = match end.checked_sub(start) {
-            None => return Err(anyhow::Error::msg("end value is overflow")),
-            Some(v) => v,
-        };
-        if gaps > MAX_RESULT_AMOUNT {
-            return Err(anyhow::Error::msg("end value is overflow"));
-        }
-
         // Since tx order is strictly incremental, traversing the SMT Tree can be optimized into a multi get query to improve query performance.
         let tx_orders: Vec<_> = if cursor.is_some() {
             ((start + 1)..=end).collect()