-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of React Native Blur view for android #13663
Conversation
Jenkins BuildsClick to see older builds (6)
|
994646f
to
30a5b44
Compare
30a5b44
to
5d54577
Compare
@@ -18,3 +18,5 @@ include ':react-native-status' | |||
project(':react-native-status').projectDir = new File(rootProject.projectDir, '../modules/react-native-status/android') | |||
include ':react-native-status-keycard' | |||
project(':react-native-status-keycard').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-status-keycard/android') | |||
include ':react-native-blur' | |||
project(':react-native-blur').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/blur/android') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project name don't allow /
@
, So instead of using @react-native-community/blur
as project name, library name is being used here. (same as ref)
@@ -16,7 +16,7 @@ | |||
"@babel/preset-typescript": "^7.17.12", | |||
"@react-native-community/async-storage": "^1.11.0", | |||
"@react-native-community/audio-toolkit": "git+https://github.com/tbenr/react-native-audio-toolkit.git#refs/tags/v2.0.3-status-v6", | |||
"@react-native-community/blur": "^3.6.0", | |||
"@react-native-community/blur": "git+https://github.com/Kureev/react-native-blur#refs/tags/v3.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3.6.1
is required for fixing crash on android while navigating (ref). But for some reason it only available on repo and not published on npm, even though it was created on Apr 27, 2021
90% of end-end tests have passed
Failed tests (8)Click to expand
Passed tests (76)Click to expand
|
fixes: #13664
Summary
PR implements React Native Blur view for android.
Entire screen inside visual area of blur-view will be blurred, except children's of blur-view.
It doesn't matter if another view inside the visual area was above or below of the blur-view. Blur-view takes a snapshot of the visual area and blurs it.
Uses
Note:
overlay-color
is required, otherwise blur-view will also affect surrounding view (ref)status: ready