Integrate new logins flows happy paths #17137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (47)
|
jrainville
force-pushed
the
feat/status-keycard-go-api-v2
branch
from
6b598ce to
51baa19
Compare
jrainville
force-pushed
the
feat/status-keycard-go-api-v2
branch
2 times, most recently
from
65416c6 to
78e4617
Compare
jrainville
added a commit
that referenced
this pull request
Jan 29, 2025
jrainville
force-pushed
the
feat/new-onbaording-login-flows
branch
from
67a41aa to
15b8543
Compare
jrainville
added a commit
that referenced
this pull request
Jan 29, 2025
jrainville
force-pushed
the
feat/new-onbaording-login-flows
branch
from
15b8543 to
e4d1a89
Compare
jrainville
force-pushed
the
feat/status-keycard-go-api-v2
branch
from
78e4617 to
ed4446e
Compare
jrainville
added a commit
that referenced
this pull request
Jan 29, 2025
jrainville
force-pushed
the
feat/new-onbaording-login-flows
branch
from
e4d1a89 to
e3a548f
Compare
micieslak
reviewed
Jan 30, 2025
Comment on lines
451
to
453
| if (error != "") { | ||
| // We should never be here since everything should be validated already | ||
| console.error("!!! ONBOARDING FINISHED WITH ERROR:", error) | ||
| // TODO show error | ||
| return | ||
| } |
There was a problem hiding this comment.
Yes, we don't need this check because of two resones
- everything should be validated
- even is not, nim side can reject the login as for any other login errors by emitting
accountLoginError
igor-sirotin
force-pushed
the
feat/status-keycard-go-api-v2
branch
from
ed4446e to
0061e2b
Compare
caybro
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Don't really have anything else than what @micieslak said
Besides the need for a rebase ;)
igor-sirotin
pushed a commit
that referenced
this pull request
Feb 4, 2025
igor-sirotin
force-pushed
the
feat/new-onbaording-login-flows
branch
from
e3a548f to
49940d9
Compare
igor-sirotin
pushed a commit
that referenced
this pull request
Feb 4, 2025
igor-sirotin
force-pushed
the
feat/new-onbaording-login-flows
branch
from
49940d9 to
0bdc533
Compare
igor-sirotin
force-pushed
the
feat/new-onbaording-login-flows
branch
from
4649f49 to
729c711
Compare
|
@micieslak please review, comments addressed 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17080
Based on top of #17127
Integrates the password and keycard flows
Affected areas
New login when the feature flag is enabled
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Password login:
login.webm
Keycard login:
keycardlogin.webm
Impact on end user
Nothing without the feature flag.
With the flag, enables people to login using the new Login flows.
No (super) unhappy paths yet, so just login with password and PIN. Wrong password and login errors are supported.
Generating a password error is hard unless you hardcode one or try to mess up the migration
How to test
export FLAG_ONBOARDING_V2_ENABLED=1 && make runRisk
Tick one:
Since it's behind the flag, no real risk. Worst case, some of the new flow has a bug or a missing edge case