remove some dependencies from PinnedMessagePopup #16435
Open
+258
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurimatias
requested review from
a team,
jrainville,
osmaczko and
glitchminer
and removed request for
a team
Jenkins BuildsClick to see older builds (7)
|
jrainville
approved these changes
Oct 1, 2024
caybro
approved these changes
Oct 1, 2024
| @@ -25,8 +25,11 @@ StatusDialog { | |||
| property string messageToUnpin | |||
| property string chatId | |||
|
|
|||
| readonly property var contactDetails: store ? store.oneToOneChatContact : null | |||
| readonly property bool isPinActionAvaliable: contactDetails ? contactDetails.isContact : true | |||
| readonly property bool isPinActionAvaliable: true | |||
There was a problem hiding this comment.
Suggested change
| readonly property bool isPinActionAvaliable: true | |
| readonly property bool isPinActionAvailable: true |
ui/app/mainui/Popups.qml
Outdated
| @@ -264,7 +264,8 @@ QtObject { | |||
| messageStore: messageStore, | |||
| pinnedMessagesModel: pinnedMessagesModel, | |||
| messageToPin: messageToPin, | |||
| chatId: chatId | |||
| chatId: chatId, | |||
| isPinActionAvaliable: store && store.oneToOneChatContact ? store.oneToOneChatContact.isContact : true | |||
There was a problem hiding this comment.
Suggested change
| isPinActionAvaliable: store && store.oneToOneChatContact ? store.oneToOneChatContact.isContact : true | |
| isPinActionAvailable: store && store.oneToOneChatContact ? store.oneToOneChatContact.isContact : true |
micieslak
requested changes
Oct 2, 2024
micieslak
reviewed
Oct 2, 2024
|
|
||
| Logs { id: logs } | ||
|
|
||
| QtObject { |
There was a problem hiding this comment.
assigning this object results with:
storybook/pages/PinnedMessagesPopupPage.qml:177:17: Unable to assign QObject_QML_12084 to MessageStore_QMLTYPE_12017
It's necessary to use mechanism of stubs here. It means that store should be imported and used in it's typed form:
import AppLayouts.Chat.stores 1.0
MessageStore {
id: mockMessageStore
// mock stuff here
}Similarly with RootStore below.
| id: pinnedMessagesPopup | ||
| store: mockRootStore | ||
| messageStore: mockMessageStore | ||
| pinnedMessagesModel: mockMessageStore.messages |
There was a problem hiding this comment.
What is expected here is model, so it should be like:
ListModel {
id: messagesModel
Component.onCompleted: {
append(messages)
}
}and messagesModel should be used in this binding here.
| id: mockMessageStore | ||
| property var messages: [ | ||
| { | ||
| messageId: "msg1", |
There was a problem hiding this comment.
Role names used here doesn't match what's expected in PinnedMessagesPopup, e.g.:
MessageView {
id: messageItem
messageId: model.id
// ...
}So messageId -> id. Some roles seem to be missing as well.
| } | ||
|
|
||
| TextField { | ||
| id: messageToPinInput |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Removes some of the dependencies on the store on PinnedMessagePopup, however some still remains because it requires refactoring the MessageView component.
Affected areas
Pinned Messages
Impact on end user
Functionality should stay the same
How to test
On Group Chats:
Risk
Might affect community pinned messages also