Fix existing asset detection #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folder setting of file fields does not work as expected.
Let's have a look at some example configuration:
Asset URL:
https://www.domain.tld/wp-content/uploads/2024/08/image.jpgBase URL:
https://www.domain.tld/wp-content/uploads/Folder:
imagesThe asset is uploaded correctly to the configured folder
imagesinstead of2024/08. However, the check for an existent asset to prevent multiple uploads does not take the new folder into account.Therefore, the assets will get uploaded again with a timestamp at the end on every new import run.
This PR solves the issue in a not so elegant way I believe. It works, but maybe someone could refactor it.