Skip to content

Conversation

@SteJW
Copy link

@SteJW SteJW commented Dec 8, 2025

I reported a bug in the statamic importer, but it's an eloquent related problem. It's also causing the a problem in the overview of taxonomies (/cp/taxonomies) with the same error.
I created a pull request for a small fix.

@ryanmitchell
Copy link
Contributor

Thanks for the PR, but this changes the default behaviour to be namespaces driven by eloquent by default, when we want the opposite when namespaces != 'all' - it should make files the default.

@SteJW
Copy link
Author

SteJW commented Dec 8, 2025

In my config I have the following:
'namespaces' => ['forms', 'navigation'],

The change keeps checking the namespaces, but it doesnt return false when a namespace is null. On line 28 of the BlueprintRepository, it will use the model when it's null

@ryanmitchell
Copy link
Contributor

The point of it returning false was for it to defer to the file repository:

if (! $this->isEloquentDrivenNamespace($namespace)) {
return parent::find($blueprint);
}

@SteJW
Copy link
Author

SteJW commented Dec 9, 2025

Doesn't it still do that with blueprints that are not in the config, hence not in the database? This should only skips null namespaces, and look for them in the database. Would there be a way to have the null namespace look for the file repository?

@ryanmitchell
Copy link
Contributor

Thats how it currently works, it looks in the file repo - thats the behaviour you have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants