[5.x] Private asset container url method should return null (#10769)

statamic · Sep 5, 2024 · 03ee12b · 03ee12b
1 parent adc37d2
commit 03ee12b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Assets/AssetContainer.php b/src/Assets/AssetContainer.php
@@ -134,6 +134,10 @@ public function path()
      */
     public function url()
     {
+        if ($this->private()) {
+            return null;
+        }
+
         $url = rtrim($this->disk()->url('/'), '/');
 
         return ($url === '') ? '/' : $url;

diff --git a/tests/Assets/AssetContainerTest.php b/tests/Assets/AssetContainerTest.php
@@ -144,11 +144,13 @@ public function its_private_if_the_disk_has_no_url()
         $container = (new AssetContainer)->disk('test');
         $this->assertTrue($container->private());
         $this->assertFalse($container->accessible());
+        $this->assertNull($container->url());
 
         Storage::fake('test', ['url' => '/url']);
 
         $this->assertFalse($container->private());
         $this->assertTrue($container->accessible());
+        $this->assertEquals('/url', $container->url());
     }
 
     #[Test]