Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wacz lightbox #3

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Add wacz lightbox #3

wants to merge 41 commits into from

Conversation

giacomobg
Copy link

No description provided.

@makew0rld
Copy link
Contributor

If this is a proof-of-concept or experiment, it might be more appropriate for the https://github.com/starlinglab/web-experiments repo. If it's a simple example others can reuse and build from, then this repo makes sense. See the website for examples.

From a quick look at the files in this PR, it looks like this might be best suited for another repo, maybe its own? It contains many files, specific to the project it was used for, and it requires a build step, whereas the other elements of this repo are simple HTML for the most part.

@YurkoWasHere
Copy link

I agree with cole

Especially if this is going to be joined with other repos (like a wordpress plugin) a monorepo model like this may become unwieldy for such bigger builds.

@walkerlj0
Copy link
Contributor

Okay @giacomobg can you take just the wacz-lightbox piece and put it in this blank repo here? https://github.com/walkerlj0/wacz-lightbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants