-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change yaml bench output format #994
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #994 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 105 105
Lines 14221 14221
Branches 14221 14221
=======================================
Hits 13123 13123
Misses 1024 1024
Partials 74 74 ☔ View full report in Codecov by Sentry. |
11f5fe7
to
e1eec49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
crates/prover/Cargo.toml
line 71 at r4 (raw file):
# [[bench]] # harness = false # name = "fft"
Revert these changes
Code quote:
# [[bench]]
# harness = false
# name = "fft"
chore: use cargo-criterion
e1eec49
to
bf8e472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r4.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
crates/prover/Cargo.toml
line 71 at r4 (raw file):
Previously, shaharsamocha7 wrote…
Revert these changes
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
No description provided.