Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change yaml bench output format #994

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

shaharsamocha7
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (438c107) to head (bf8e472).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #994   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         105      105           
  Lines       14221    14221           
  Branches    14221    14221           
=======================================
  Hits        13123    13123           
  Misses       1024     1024           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alon-dotan-starkware alon-dotan-starkware force-pushed the shahars/test/bench branch 10 times, most recently from 11f5fe7 to e1eec49 Compare January 15, 2025 14:02
Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion


crates/prover/Cargo.toml line 71 at r4 (raw file):

# [[bench]]
# harness = false
# name = "fft"

Revert these changes

Code quote:

# [[bench]]
# harness = false
# name = "fft"

Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r4.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @shaharsamocha7)


crates/prover/Cargo.toml line 71 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Revert these changes

Done

Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @shaharsamocha7)

Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@alon-dotan-starkware alon-dotan-starkware marked this pull request as ready for review January 19, 2025 08:26
@alon-dotan-starkware alon-dotan-starkware enabled auto-merge (squash) January 19, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants