Unite impls of DomainEvaluationAccumulator #936
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
Gali-StarkWare
force-pushed
the
12-16-generic_backend_secure_power_generation
branch
from
7e1be59 to
3bfc747
Compare
Gali-StarkWare
force-pushed
the
12-17-unite_impls_of_domainevaluationaccumulator
branch
2 times, most recently
from
5df95d0 to
7d9b756
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #936 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 99 99
Lines 13818 13818
Branches 13818 13818
=======================================
Hits 12638 12638
Misses 1065 1065
Partials 115 115 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: d0c8038 | Previous: 7d9b756 | Ratio |
|---|---|---|---|
iffts/simd ifft/21 |
6175818 ns/iter (± 117800) |
3057935 ns/iter (± 49649) |
2.02 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Gali-StarkWare
force-pushed
the
12-17-unite_impls_of_domainevaluationaccumulator
branch
8 times, most recently
from
d0c8038 to
7ba577a
Compare
Gali-StarkWare
changed the base branch from
12-16-generic_backend_secure_power_generation
to
12-10-add_secure_powers_generation_for_simd
Gali-StarkWare
force-pushed
the
12-17-unite_impls_of_domainevaluationaccumulator
branch
from
7ba577a to
145bba4
Compare
Gali-StarkWare
changed the base branch from
12-10-add_secure_powers_generation_for_simd
to
12-16-generic_backend_secure_power_generation
Gali-StarkWare
force-pushed
the
12-16-generic_backend_secure_power_generation
branch
from
3bfc747 to
d133010
Compare
Gali-StarkWare
force-pushed
the
12-17-unite_impls_of_domainevaluationaccumulator
branch
from
145bba4 to
119ff86
Compare
Gali-StarkWare
changed the base branch from
12-16-generic_backend_secure_power_generation
to
graphite-base/936
Gali-StarkWare
force-pushed
the
12-17-unite_impls_of_domainevaluationaccumulator
branch
from
119ff86 to
9eb2221
Compare
No description provided.