Expression evaluator: Ordnung muß sein.

[Alon-Ti]

No description provided.

[reviewable-StarkWare]

This change is 

[Alon-Ti]

• Expression evaluator: Ordnung muß sein. #927 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.05148% with 83 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (c2780f7) to head (5006de5).
Report is 2 commits behind head on dev.

Files with missing lines	Patch %	Lines
crates/prover/src/constraint_framework/expr/mod.rs	51.38%	67 Missing and 3 partials ⚠️
.../prover/src/constraint_framework/expr/evaluator.rs	95.95%	7 Missing ⚠️
...tes/prover/src/constraint_framework/expr/format.rs	90.24%	4 Missing ⚠️
...s/prover/src/constraint_framework/expr/simplify.rs	97.95%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #927      +/-   ##
==========================================
+ Coverage   91.41%   91.53%   +0.11%     
==========================================
  Files          94       98       +4     
  Lines       13740    13927     +187     
  Branches    13740    13927     +187     
==========================================
+ Hits        12561    12748     +187     
+ Misses       1064     1062       -2     
- Partials      115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Alon-Ti)

---

a discussion (no related file):
You are not German yet

---

crates/prover/src/constraint_framework/expr/eval.rs line 1 at r1 (raw file):

use std::collections::{HashMap, HashSet};

I'm not sure about this file name
You also have evaluator.rs for the evaluations

[shaharsamocha7]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Alon-Ti)

---

a discussion (no related file):

Previously, shaharsamocha7 wrote…

You are not German yet

Very nice PR!

[Alon-Ti]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/expr/eval.rs line 1 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I'm not sure about this file name
You also have evaluator.rs for the evaluations

Done.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

[shaharsamocha7]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: 5006de5	Previous: cd8b37b	Ratio
iffts/simd ifft/22	12859691 ns/iter (± 175409)	6306399 ns/iter (± 210024)	2.04
merkle throughput/simd merkle	28780342 ns/iter (± 499980)	13712527 ns/iter (± 579195)	2.10

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7