Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relation tracker bug fix #921

Merged
merged 1 commit into from
Dec 4, 2024
Merged

relation tracker bug fix #921

merged 1 commit into from
Dec 4, 2024

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (f519bb6) to head (0b458b5).

Files with missing lines Patch % Lines
...rover/src/constraint_framework/relation_tracker.rs 50.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #921      +/-   ##
==========================================
- Coverage   91.51%   91.43%   -0.09%     
==========================================
  Files          94       94              
  Lines       13666    13686      +20     
  Branches    13666    13686      +20     
==========================================
+ Hits        12507    12514       +7     
- Misses       1044     1057      +13     
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 0b458b5 Previous: cd8b37b Ratio
iffts/simd ifft/22 13011227 ns/iter (± 84893) 6306399 ns/iter (± 210024) 2.06
merkle throughput/simd merkle 30283861 ns/iter (± 580284) 13712527 ns/iter (± 579195) 2.21

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware merged commit 76af3c6 into dev Dec 4, 2024
17 of 19 checks passed
@ohad-starkware ohad-starkware deleted the ohad/tracker_bug branch December 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants