Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machete version #914

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix machete version #914

merged 1 commit into from
Dec 5, 2024

Conversation

shaharsamocha7
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (76af3c6) to head (09860e0).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #914   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          94       94           
  Lines       13686    13686           
  Branches    13686    13686           
=======================================
  Hits        12514    12514           
  Misses       1057     1057           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaharsamocha7 shaharsamocha7 force-pushed the 11-28-Fix_machete_version branch 3 times, most recently from 6727c0b to 50b2e3f Compare November 28, 2024 15:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 09860e0 Previous: cd8b37b Ratio
merkle throughput/simd merkle 27812531 ns/iter (± 585533) 13712527 ns/iter (± 579195) 2.03

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@shaharsamocha7 shaharsamocha7 force-pushed the 11-28-Fix_machete_version branch from 50b2e3f to 227bde8 Compare November 28, 2024 15:16
Copy link

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


.github/workflows/ci.yaml line 200 at r2 (raw file):

      - uses: actions/checkout@v4
      - name: Run Machete (detect unused dependencies)
        uses: bnjbvr/[email protected]

We had the same issue on the stwo-brainfuck, we inlined the cargo-machete action and used the --locked flag when installing cargo-machete, to still use [email protected] and not [email protected] which is not supported on rustc 1.77 (used by nightly-2024-01-04)

  machete:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: dtolnay/rust-toolchain@master
        with:
          toolchain: nightly-2024-01-04
      - uses: Swatinem/rust-cache@v2
      - run: cargo +nightly-2024-01-04 install --locked cargo-machete
      - name: Run Machete (detect unused dependencies)
        uses: cargo +nightly-2024-01-04 machete

@shaharsamocha7 shaharsamocha7 force-pushed the 11-28-Fix_machete_version branch from 227bde8 to d8c2940 Compare December 5, 2024 14:26
@shaharsamocha7 shaharsamocha7 force-pushed the 11-28-Fix_machete_version branch from d8c2940 to 09860e0 Compare December 5, 2024 14:38
Copy link
Collaborator Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @zmalatrax)


.github/workflows/ci.yaml line 200 at r2 (raw file):

Previously, zmalatrax (malatrax) wrote…

We had the same issue on the stwo-brainfuck, we inlined the cargo-machete action and used the --locked flag when installing cargo-machete, to still use [email protected] and not [email protected] which is not supported on rustc 1.77 (used by nightly-2024-01-04)

  machete:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: dtolnay/rust-toolchain@master
        with:
          toolchain: nightly-2024-01-04
      - uses: Swatinem/rust-cache@v2
      - run: cargo +nightly-2024-01-04 install --locked cargo-machete
      - name: Run Machete (detect unused dependencies)
        uses: cargo +nightly-2024-01-04 machete

ty

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @zmalatrax)

@shaharsamocha7 shaharsamocha7 merged commit ef6667a into dev Dec 5, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants