-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix machete version #914
Fix machete version #914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #914 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 94 94
Lines 13686 13686
Branches 13686 13686
=======================================
Hits 12514 12514
Misses 1057 1057
Partials 115 115 ☔ View full report in Codecov by Sentry. |
6727c0b
to
50b2e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: 09860e0 | Previous: cd8b37b | Ratio |
---|---|---|---|
merkle throughput/simd merkle |
27812531 ns/iter (± 585533 ) |
13712527 ns/iter (± 579195 ) |
2.03 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
50b2e3f
to
227bde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
.github/workflows/ci.yaml
line 200 at r2 (raw file):
- uses: actions/checkout@v4 - name: Run Machete (detect unused dependencies) uses: bnjbvr/[email protected]
We had the same issue on the stwo-brainfuck
, we inlined the cargo-machete action and used the --locked
flag when installing cargo-machete
, to still use [email protected]
and not [email protected]
which is not supported on rustc 1.77 (used by nightly-2024-01-04)
machete:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2024-01-04
- uses: Swatinem/rust-cache@v2
- run: cargo +nightly-2024-01-04 install --locked cargo-machete
- name: Run Machete (detect unused dependencies)
uses: cargo +nightly-2024-01-04 machete
227bde8
to
d8c2940
Compare
d8c2940
to
09860e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @zmalatrax)
.github/workflows/ci.yaml
line 200 at r2 (raw file):
Previously, zmalatrax (malatrax) wrote…
We had the same issue on the
stwo-brainfuck
, we inlined the cargo-machete action and used the--locked
flag when installingcargo-machete
, to still use[email protected]
and not[email protected]
which is not supported on rustc 1.77 (used by nightly-2024-01-04)machete: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@master with: toolchain: nightly-2024-01-04 - uses: Swatinem/rust-cache@v2 - run: cargo +nightly-2024-01-04 install --locked cargo-machete - name: Run Machete (detect unused dependencies) uses: cargo +nightly-2024-01-04 machete
ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @zmalatrax)
No description provided.