Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preprocessed typo #910

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/prover/src/constraint_framework/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ impl TraceLocationAllocator {
}

/// Create a new `TraceLocationAllocator` with fixed preprocessed columns setup.
pub fn new_with_preproccessed_columns(preprocessed_columns: &[PreprocessedColumn]) -> Self {
pub fn new_with_preprocessed_columns(preprocessed_columns: &[PreprocessedColumn]) -> Self {
Self {
next_tree_offsets: Default::default(),
preprocessed_columns: preprocessed_columns
Expand Down Expand Up @@ -212,7 +212,7 @@ impl<E: FrameworkEval> Component for FrameworkComponent<E> {
})
}

fn preproccessed_column_indices(&self) -> ColumnVec<usize> {
fn preprocessed_column_indices(&self) -> ColumnVec<usize> {
self.preprocessed_column_indices.clone()
}

Expand Down
4 changes: 2 additions & 2 deletions crates/prover/src/core/air/components.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl<'a> Components<'a> {
*preprocessed_mask_points = vec![vec![]; self.n_preprocessed_columns];

for component in &self.components {
for idx in component.preproccessed_column_indices() {
for idx in component.preprocessed_column_indices() {
preprocessed_mask_points[idx] = vec![point];
}
}
Expand Down Expand Up @@ -73,7 +73,7 @@ impl<'a> Components<'a> {
let component_trace_log_sizes = component.trace_log_degree_bounds();

for (column_index, &log_size) in zip(
component.preproccessed_column_indices(),
component.preprocessed_column_indices(),
&component_trace_log_sizes[PREPROCESSED_TRACE_IDX],
) {
let column_log_size = &mut preprocessed_columns_trace_log_sizes[column_index];
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/core/air/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub trait Component {
point: CirclePoint<SecureField>,
) -> TreeVec<ColumnVec<Vec<CirclePoint<SecureField>>>>;

fn preproccessed_column_indices(&self) -> ColumnVec<usize>;
fn preprocessed_column_indices(&self) -> ColumnVec<usize>;

/// Evaluates the constraint quotients combination of the component at a point.
fn evaluate_constraint_quotients_at_point(
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/examples/blake/air.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ impl BlakeComponents {
.iter()
.map(|l| PreprocessedColumn::IsFirst(log_size + l));

let tree_span_provider = &mut TraceLocationAllocator::new_with_preproccessed_columns(
let tree_span_provider = &mut TraceLocationAllocator::new_with_preprocessed_columns(
&chain!(
[scheduler_is_first_column],
blake_round_is_first_columns_iter,
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/examples/wide_fibonacci/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ mod tests {
let mut commitment_scheme =
CommitmentSchemeProver::<SimdBackend, Poseidon252MerkleChannel>::new(config, &twiddles);

// TODO(ilya): remove the following once preproccessed columns are not mandatory.
// TODO(ilya): remove the following once preprocessed columns are not mandatory.
// Preprocessed trace
let mut tree_builder = commitment_scheme.tree_builder();
tree_builder.extend_evals([]);
Expand Down
8 changes: 4 additions & 4 deletions crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ impl<'twiddles, 'oracle, O: MleCoeffColumnOracle> Component
})
}

fn preproccessed_column_indices(&self) -> ColumnVec<usize> {
fn preprocessed_column_indices(&self) -> ColumnVec<usize> {
vec![]
}

Expand Down Expand Up @@ -358,7 +358,7 @@ impl<'oracle, O: MleCoeffColumnOracle> Component for MleEvalVerifierComponent<'o
})
}

fn preproccessed_column_indices(&self) -> ColumnVec<usize> {
fn preprocessed_column_indices(&self) -> ColumnVec<usize> {
vec![]
}

Expand Down Expand Up @@ -794,7 +794,7 @@ mod tests {
let mut commitment_scheme =
CommitmentSchemeProver::<_, Blake2sMerkleChannel>::new(config, &twiddles);
let channel = &mut Blake2sChannel::default();
// TODO(ilya): remove the following once preproccessed columns are not mandatory.
// TODO(ilya): remove the following once preprocessed columns are not mandatory.
// Preprocessed trace
let mut tree_builder = commitment_scheme.tree_builder();
tree_builder.extend_evals([]);
Expand Down Expand Up @@ -870,7 +870,7 @@ mod tests {
CommitmentSchemeProver::<_, Blake2sMerkleChannel>::new(config, &twiddles);
let channel = &mut Blake2sChannel::default();

// TODO(ilya): remove the following once preproccessed columns are not mandatory.
// TODO(ilya): remove the following once preprocessed columns are not mandatory.
// Preprocessed trace
let mut tree_builder = commitment_scheme.tree_builder();
tree_builder.extend_evals([]);
Expand Down