Skip to content

Commit

Permalink
Remove outdated comment. (#906)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ilyalesokhin-starkware
ilyalesokhin-starkware authored Nov 28, 2024
1 parent 4d64300 commit 9b25738
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions crates/prover/src/core/vcs/verifier.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ impl<H: MerkleHasher> MerkleVerifier<H> {
/// * The column values are too short (missing values).
/// * The computed root does not match the expected root.
///
/// # Panics
///
/// This function will panic if the `values` vector is not sorted in descending order based on
/// the `log_size` of the columns.
///
/// # Returns
///
/// Returns `Ok(())` if the decommitment is successfully verified.
Expand Down

1 comment on commit 9b25738

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 9b25738 Previous: cd8b37b Ratio
iffts/simd ifft/25 138551381 ns/iter (± 1897418) 65891527 ns/iter (± 1735211) 2.10
iffts/simd ifft/26 288598885 ns/iter (± 4399714) 136655216 ns/iter (± 2242165) 2.11
iffts/simd ifft/27 662298755 ns/iter (± 21894798) 312588285 ns/iter (± 9816879) 2.12
iffts/simd ifft/28 1342398007 ns/iter (± 23948011) 643771030 ns/iter (± 19147376) 2.09
merkle throughput/simd merkle 28665864 ns/iter (± 467640) 13712527 ns/iter (± 579195) 2.09

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Please sign in to comment.