Skip to content

Commit

Permalink
Fix clippy const function error (#913)
Browse files Browse the repository at this point in the history
Clippy const function - fix merge error
  • Loading branch information
shaharsamocha7 authored Nov 28, 2024
2 parents c2ef3ac + a0cce5c commit 9a9ae36
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/prover/src/constraint_framework/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl TraceLocationAllocator {
}
}

pub fn preprocessed_columns(&self) -> &HashMap<PreprocessedColumn, usize> {
pub const fn preprocessed_columns(&self) -> &HashMap<PreprocessedColumn, usize> {
&self.preprocessed_columns
}

Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/constraint_framework/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ pub struct RelationEntry<'a, F: Clone, EF: RelationEFTraitBound<F>, R: Relation<
values: &'a [F],
}
impl<'a, F: Clone, EF: RelationEFTraitBound<F>, R: Relation<F, EF>> RelationEntry<'a, F, EF, R> {
pub fn new(relation: &'a R, multiplicity: EF, values: &'a [F]) -> Self {
pub const fn new(relation: &'a R, multiplicity: EF, values: &'a [F]) -> Self {
Self {
relation,
multiplicity,
Expand Down

1 comment on commit 9a9ae36

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 9a9ae36 Previous: cd8b37b Ratio
merkle throughput/simd merkle 29896490 ns/iter (± 550832) 13712527 ns/iter (± 579195) 2.18

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Please sign in to comment.