-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply prettier, upgrade Node, add PR template #258
base: v0.8.0
Are you sure you want to change the base?
Conversation
Thanks for the much-needed PR We should merge it as the last PR of 0.8.0 so we don't create too many conflicts with open PRs. Question: is this with the formatting already applied to all the files? or only partially? (asking because I'm getting file changes after running the scripts) Also, |
Thanks for the review @amanusk! I'm ok with this being the last PR of 0.8.0 The formatting is already applied, I didn't get any new changes besides the ones resulting from merging with the target branch where my other PR was recently merged and needed formatting. Those changes can be seen in one of my last commits: 4ff04b5. Perhaps the horrible output on I improved the output of formatting check to make it user friendly and renamed the command from Prettier relies on the locally present #!/bin/sh
set -euo pipefail
npm run validate_all
npm run check_component_uniqueness
npm run format_check That way, all CI checks shall be performed before committing, disallowing the commit if anything fails. |
prettier
as devDependency in package.json.editorconfig
with.prettierrc
.js
,.json
,.md
files.npm run format
- to be invoked locallynpm run format_check
- to be invoked as a CI step - updatedvalidate.yml
.github/pull_request_template.md
to serve as a reminder to contributors